summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFurkan Sahin <furkan-dev@proton.me>2023-10-24 15:24:51 +0300
committerFurkan Sahin <furkan-dev@proton.me>2023-10-24 15:24:51 +0300
commitb2ee1247bdf03efef096ef7eedd5ff4586553191 (patch)
tree1d98ec32e74521be86e606ce5813de8c2efa9710
parent90e70aa9c58d2921f62b37027f140b0775086b1b (diff)
view: check if the buffer was uploaded on save
wlr_surface_has_buffer() is insufficient; if a client has committed a buffer but it couldn't be applied, NULL deref happens in the next line.
-rw-r--r--sway/tree/view.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sway/tree/view.c b/sway/tree/view.c
index ec54fed8..a9035de7 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -1422,7 +1422,7 @@ static void view_save_buffer_iterator(struct wlr_surface *surface,
int sx, int sy, void *data) {
struct sway_view *view = data;
- if (surface && wlr_surface_has_buffer(surface)) {
+ if (surface && surface->buffer) {
wlr_buffer_lock(&surface->buffer->base);
struct sway_saved_buffer *saved_buffer = calloc(1, sizeof(struct sway_saved_buffer));
saved_buffer->buffer = surface->buffer;