desktop/output: Clear repaint timer earlier in destroy

The teardown of a sway_output is split in two: begin_destroy and
output_destroy. The former clears some state such as NULL'ing the
reference to wlr_output, while the latter frees the struct and its
remaining resources.

If an output is destroyed while a repaint timer is pending, future frame
callbacks will no longer occur as the listener is torn down in
begin_destroy, but the repaint timer is not torn down and may still
fire until output_destroy is hit. As begin_destroy cleared the reference
to wlr_output, this leads to a NULL-pointer dereference.

Tear down the repaint timer in begin_destroy as there is no need for it.

Fixes: bfa1dc8e5ad0 ("desktop/output: Clear frame_pending even output is disabled")

2 files changed, 3 insertions, 1 deletions

diff --git a/sway/desktop/output.c b/sway/desktop/output.c
index c7ad8f93..607eca2c 100644
--- a/sway/desktop/output.c
+++ b/sway/desktop/output.c
@@ -440,6 +440,9 @@ static void begin_destroy(struct sway_output *output) {
 	output->wlr_output->data = NULL;
 	output->wlr_output = NULL;
 
+	wl_event_source_remove(output->repaint_timer);
+	output->repaint_timer = NULL;
+
 	request_modeset();
 }
 
diff --git a/sway/tree/output.c b/sway/tree/output.c
index 44b941ca..65d9e3e7 100644
--- a/sway/tree/output.c
+++ b/sway/tree/output.c
@@ -273,7 +273,6 @@ void output_destroy(struct sway_output *output) {
 	destroy_scene_layers(output);
 	list_free(output->workspaces);
 	list_free(output->current.workspaces);
-	wl_event_source_remove(output->repaint_timer);
 	wlr_color_transform_unref(output->color_transform);
 	free(output);
 }