aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFurkan Sahin <furkan-dev@proton.me>2020-03-13 03:50:37 +0900
committerFurkan Sahin <furkan-dev@proton.me>2020-03-13 03:50:37 +0900
commitde68456d40ce6ad3c84f8d24a0ad067cf4ea9e76 (patch)
tree7a22df4764204c4ca1ef2587b9b1cf3894e394b5
parentb3f6dcb688411235f45ead950db9a3c63230cb2e (diff)
Limit workspace numbers within 0..INT32_MAX
See https://github.com/i3/i3/commit/83c7aff089a6728b6e522d934d656a8e09463112
-rw-r--r--sway/ipc-json.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/sway/ipc-json.c b/sway/ipc-json.c
index d3731092..1ebc3bd2 100644
--- a/sway/ipc-json.c
+++ b/sway/ipc-json.c
@@ -384,8 +384,19 @@ static json_object *ipc_json_describe_scratchpad_output(void) {
static void ipc_json_describe_workspace(struct sway_workspace *workspace,
json_object *object) {
- int num = isdigit(workspace->name[0]) ? atoi(workspace->name) : -1;
-
+ int num;
+ if (isdigit(workspace->name[0])) {
+ errno = 0;
+ char *endptr = NULL;
+ long long parsed_num = strtoll(workspace->name, &endptr, 10);
+ if (errno != 0 || parsed_num > INT32_MAX || parsed_num < 0 || endptr == workspace->name) {
+ num = -1;
+ } else {
+ num = (int) parsed_num;
+ }
+ } else {
+ num = -1;
+ }
json_object_object_add(object, "num", json_object_new_int(num));
json_object_object_add(object, "fullscreen_mode", json_object_new_int(1));
json_object_object_add(object, "output", workspace->output ?